linux-kernel - Re: [patch 01/21] move isolate_lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080229114638.66E4.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Fri, 29 Feb 2008 11:47:14 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Rik van Riel <riel@...hat.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	Lee Schermerhorn <Lee.Schermerhorn@...com>, linux-mm@...ck.org,
	Nick Piggin <npiggin@...e.de>
Subject: Re: [patch 01/21] move isolate_lru_page() to vmscan.c


> If I understand you right, this is what the incremental patch looks like:
> 
> Index: linux-2.6.25-rc2-mm1/mm/migrate.c
> ===================================================================
> --- linux-2.6.25-rc2-mm1.orig/mm/migrate.c	2008-02-28 21:32:20.000000000 -0500
> +++ linux-2.6.25-rc2-mm1/mm/migrate.c	2008-02-28 21:32:14.000000000 -0500
> @@ -841,16 +841,10 @@ static int do_move_pages(struct mm_struc
>  			goto put_and_set;
>  
>  		err = isolate_lru_page(page);
> -		if (err) {
> -put_and_set:
> -			/*
> -			 * Either remove the duplicate refcount from
> -			 * isolate_lru_page() or drop the page ref if it was
> -			 * not isolated.
> -			 */
> -			put_page(page);
> -		} else
> +		if (!err)
>  			list_add_tail(&page->lru, &pagelist);
> +put_and_set:
> +		put_page(page);
>  set_status:
>  		pp->status = err;
>  	}
> 
> Is this OK for me to commit to my tree?
> (folding it into patch 01/21)

Yes. thanks.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/