linux-kernel - Re: [PATCH] x86 pci: remove checking type for mmconfig probe v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080304062321.GB16019@kroah.com>
Date:	Mon, 3 Mar 2008 22:23:21 -0800
From:	Greg KH <greg@...ah.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86 pci: remove checking type for mmconfig probe v2

On Sat, Mar 01, 2008 at 12:36:50AM -0800, Yinghai Lu wrote:
> On Fri, Feb 29, 2008 at 10:02 PM, Greg KH <greg@...ah.com> wrote:
> > On Thu, Feb 28, 2008 at 11:56:50PM -0800, Yinghai Lu wrote:
> >  >
> >  > doesn't need to check if it is type1 or type2. we can use raw_pci_ops dirctly.
> >
> >  Why?  is this because the ops are already set up?  It would be nice to
> >  add the "why this change is necessary and/or possible now" for the
> >  changelog.
> yes.
> raw_pci_ops got assigned when check direct_type1 and direct_type2.
> and could used in hostbridge check to get MMCONF base.
> 
> make mmconfig probe clean
> with checking if raw_pci_ops is assigned instead of passing type or
> checking type.

Ah, ok, that makes sense, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/