linux-kernel - Re: [PATCH 06/14] drivers/s390: replace remaining __FUNCTION_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080304011521.98a20055.akpm@linux-foundation.org>
Date:	Tue, 4 Mar 2008 01:15:21 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	schwidefsky@...ibm.com
Cc:	Harvey Harrison <harvey.harrison@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/14] drivers/s390: replace remaining __FUNCTION__
 occurrences

On Tue, 04 Mar 2008 09:55:07 +0100 Martin Schwidefsky <schwidefsky@...ibm.com> wrote:

> On Mon, 2008-03-03 at 19:09 -0800, Harvey Harrison wrote:
> > __FUNCTION__ is gcc-specific, use __func__
> > 
> > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > ---
> >  drivers/s390/block/dasd.c        |    4 +-
> >  drivers/s390/char/tape_34xx.c    |    2 +-
> >  drivers/s390/char/vmwatchdog.c   |    4 +-
> >  drivers/s390/char/zcore.c        |    2 +-
> >  drivers/s390/cio/device_status.c |    2 +-
> >  drivers/s390/crypto/zcrypt_api.h |    8 +-
> >  drivers/s390/net/claw.c          |  344 +++++++++++++++++++-------------------
> >  drivers/s390/net/ctcmain.c       |  112 ++++++------
> >  drivers/s390/net/netiucv.c       |   96 ++++++------
> >  drivers/s390/s390mach.c          |    8 +-
> >  drivers/s390/scsi/zfcp_def.h     |    2 +-
> >  11 files changed, 292 insertions(+), 292 deletions(-)
> 
> Urgh, is this really necessary? The linux kernel is always compiled with
> gcc for s390. Yes __func__ is a bit shorter and maybe even looks nicer
> than __FUNCTION__ but is it really worth the trouble ? 
> 

That's what everyone is asking ;)

Unfortunately, __func__ is preferred and __FUNCTION__ is deprecated.  So
the patch converts your code from "wrong" to "right".  Even though it was
only a teeny bit wrong.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/