linux-kernel - Re: [PATCH 06/17] Change the kernel configurated RapidIO system size to auto-probing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080304212012.9ea2d3b5.sfr@canb.auug.org.au>
Date:	Tue, 4 Mar 2008 21:20:12 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Zhang Wei <wei.zhang@...escale.com>
Cc:	mporter@...nel.crashing.org, galak@...nel.crashing.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/17] Change the kernel configurated RapidIO system
 size to auto-probing.

On Wed,  5 Mar 2008 00:29:51 +0800 Zhang Wei <wei.zhang@...escale.com> wrote:
>
> +	if (!(rionet_active = (struct rio_dev **)__get_free_pages(GFP_KERNEL,
> +				mport->sys_size ? __ilog2(sizeof(void *)) + 4
> +				: 0))) {

Please separate the assignment from the test.

> +		if (!(rswitch->route_table = kzalloc(sizeof(u8)*
> +					RIO_MAX_ROUTE_ENTRIES(port->sys_size),
> +					GFP_KERNEL))) {

Again.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped