linux-kernel - Re: [PATCH 11/17] Add memory mapping driver to RapidIO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080304213735.c77d6203.sfr@canb.auug.org.au>
Date:	Tue, 4 Mar 2008 21:37:35 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Zhang Wei <wei.zhang@...escale.com>
Cc:	mporter@...nel.crashing.org, galak@...nel.crashing.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO.

On Wed,  5 Mar 2008 00:29:56 +0800 Zhang Wei <wei.zhang@...escale.com> wrote:
>
> +	if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size,
> +				&rmem->iores.start, GFP_KERNEL))) {

Please separate assignments from tests.

> +	if ((ret = rio_space_claim(rmem))) {

Again.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped