linux-kernel - RE: [PATCH 11/17] Add memory mapping driver to RapidIO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ABF87B0B6A38C0458E319AC973ED68AECE4522@zch01exm26.fsl.freescale.net>
Date:	Wed, 5 Mar 2008 09:59:38 +0800
From:	"Zhang Wei" <Wei.Zhang@...escale.com>
To:	"Stephen Rothwell" <sfr@...b.auug.org.au>
Cc:	<mporter@...nel.crashing.org>, <galak@...nel.crashing.org>,
	<linuxppc-dev@...abs.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 11/17] Add memory mapping driver to RapidIO.

Hi, Stephen,

Thanks! I'm considering to commit a updated patch or new code cleaning
patch.
How about your idea?

Cheers!
Wei 

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@...b.auug.org.au] 
> Sent: Tuesday, March 04, 2008 6:38 PM
> To: Zhang Wei
> Cc: mporter@...nel.crashing.org; galak@...nel.crashing.org; 
> linuxppc-dev@...abs.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO.
> 
> On Wed,  5 Mar 2008 00:29:56 +0800 Zhang Wei 
> <wei.zhang@...escale.com> wrote:
> >
> > +	if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size,
> > +				&rmem->iores.start, GFP_KERNEL))) {
> 
> Please separate assignments from tests.
> 
> > +	if ((ret = rio_space_claim(rmem))) {
> 
> Again.
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@...b.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/