linux-kernel - Re: [patch 1/2] x86, fpu: split FPU state from task struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080304205353.GA31546@elte.hu>
Date:	Tue, 4 Mar 2008 21:53:53 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	hpa@...or.com, tglx@...utronix.de, andi@...stfloor.org,
	hch@...radead.org, linux-kernel@...r.kernel.org,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [patch 1/2] x86, fpu: split FPU state from task struct - v3


* Suresh Siddha <suresh.b.siddha@...el.com> wrote:

> >   v3: Fixed the non-atomic calling sequence in atomic context.
> > 
> > is that the same bug?
> 
> Yes. Sorry for not pointing out explicitly. Essentially 32bit kernel 
> with CONFIG_PREEMPT is calling math_state_restore() with interrupts 
> disabled. Handled this by enabling/disabling the interrupts around the 
> blocking call. with small code changes ensuring that it is safe to 
> enable/disable interrupts at this point.
> 
> Do you want a v4 or separate patch for handling the kmem_cache_alloc() 
> failure

would be nice to resend a v4 - i couldnt pick v3 up due to the pending 
questions. (the NULL thing was quite serious)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/