linux-kernel - Re: [patch 1/2] x86, fpu: split FPU state from task struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080306123907.GB12232@infradead.org>
Date:	Thu, 6 Mar 2008 07:39:07 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	Christoph Hellwig <hch@...radead.org>, mingo@...e.hu,
	hpa@...or.com, tglx@...utronix.de, andi@...stfloor.org,
	linux-kernel@...r.kernel.org,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [patch 1/2] x86, fpu: split FPU state from task struct - v3

On Mon, Mar 03, 2008 at 05:36:49PM -0800, Suresh Siddha wrote:
> > You're still adding a second hook instead of re-using or re-naming
> > setup_thread_stack.  Did I miss a good explanation for that
> > or was this just an oversight?
> 
> Not an oversight. setup_thread_stack comes with its own baggage called
> __HAVE_THREAD_FUNCTIONS. Thought of keeping this simple and separate
> by using an inline or weak linkage.

Well, just switching setup_thread_stack to use whatever you use for your
current callout fixes that.  I really don't want to arch callout doing
the same thing in almost the same place, this leads to twisted and
unreadable code.  Please fix this last bit up and you'll get my full
ACK.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/