lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Mar 2008 23:09:55 -0800 From: Harvey Harrison <harvey.harrison@...il.com> To: Ingo Molnar <mingo@...e.hu> Cc: Christopher Li <sparse@...isli.org>, Julia Lawall <julia@...u.dk>, yi.zhu@...el.com, linux-wireless@...r.kernel.org, ipw3945-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, Alexander Viro <viro@....linux.org.uk>, linux-sparse@...r.kernel.org, Josh Triplett <josh@...edesktop.org> Subject: Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote: > * Christopher Li <sparse@...isli.org> wrote: > > > I think Al Viro has sent a patch to linux-sparse with subject "[PATCH > > 3/3] catch !x & y brainos" does exactly that. > > ah - nice :-) > > /me checks the linux-sparse archive > > Al's patch is: > > + if (op == '&' && expr->left->type == EXPR_PREOP && > + expr->left->op == '!') > + warning(expr->pos, "dubious: !x & y"); > > i think there might be similar patterns: "x & !y", "!x | y", "x | !y" ? > Well, (!x & y) and (!x | y) are probably the two that might have been intended otherwise. (x & !y), (x | !y) are probably ok. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists