linux-kernel - Re: [PATCH] x86: fix typo(?) in step.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080306113413.GD17906@elte.hu>
Date:	Thu, 6 Mar 2008 12:34:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Roland McGrath <roland@...hat.com>
Cc:	Jan Beulich <jbeulich@...ell.com>, tglx@...utronix.de,
	hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: fix typo(?) in step.c

* Roland McGrath <roland@...hat.com> wrote:

> The block-step test only tested that PTRACE_SINGLEBLOCK worked right. 
> I just souped it up to also test that PTRACE_SINGLESTEP still works 
> immediately afterwards.  This still does not show any problem from 
> this bug.  The case that would be broken by it is rather more arcane.  
> I haven't worked out the test case that fails with the bogon.

my interpretation of the bug would be that we fail to mask out the 
block-step MSR bit [because we mask out bit 25 instead of bit 1], and 
hence the bug would cause that MSR bit to stay enabled in other tasks 
too.

So in theory the bug should manifest itself as block-step mode never 
clearing itself, once activated. (but this would never leak into other 
tasks because we've got the thread.debugctlmsr abstraction that protects 
them)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/