linux-kernel - Re: [PATCH] x86_64: show apicid for cpu in proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8763w0gjut.fsf@basil.nowhere.org>
Date:	06 Mar 2008 12:41:46 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64: show apicid for cpu in proc

"Yinghai Lu" <yhlu.kernel@...il.com> writes:

>  			   cpus_weight(per_cpu(cpu_core_map, cpu)));
>  		seq_printf(m, "core id\t\t: %d\n", c->cpu_core_id);
>  		seq_printf(m, "cpu cores\t: %d\n", c->booted_cores);
> +		seq_printf(m, "apicid\t: %02x\n", c->apicid);

Seems a little redundant with the boot log, but ok.

But it's unclear to the user which apic ID is meant by that. There are
two different ones. The one in the LAPIC mapping and the one reported by
CPUID. They are not necessarily the same. I think you should clarify that
by renaming the field or perhaps report both.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/