linux-kernel - Re: [RFC][PATCH] PM: Make PM core handle device registrations concurrent with suspend/hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0803061022150.4061-100000@iolanthe.rowland.org>
Date:	Thu, 6 Mar 2008 10:26:58 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	pm list <linux-pm@...ts.linux-foundation.org>,
	Alexey Starikovskiy <astarikovskiy@...e.de>,
	Pavel Machek <pavel@....cz>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH] PM: Make PM core handle device registrations
 concurrent with suspend/hibernation

On Thu, 6 Mar 2008, Rafael J. Wysocki wrote:

> > > Revised patch below.
> > 
> > It looks good.  Let's hope it doesn't mess up ACPI too badly...  :-)
> > 
> > Acked-by: Alan Stern <stern@...land.harvard.edu>
> 
> Thanks!

I thought of one more thing you might want to add: device_pm_add() 
doesn't handle the case where dev->parent is NULL.  You could put in 
that static "all_devices_sleeping" flag, which gets set at the end of 
dpm_suspend() and cleared at the start of dpm_resume().

> Okay, I also have the appended patch on top of this one. :-)
> 
> Rafael
> 
> ---
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Include dpm_sysfs_add() into device_pm_add(), in analogy with
> device_pm_remove(), and modify device_add() to call the latter after
> bus_add_device(), to avoid situations in which the PM core may
> attempt to suspend a device the registration of which has not been
> successful.

Clean and simple.  Ack.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/