linux-kernel - Re: [patch -mm 4/4] mempolicy: remove includes for duplicate headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Mar 2008 14:19:23 -0600
From:	Paul Jackson <pj@....com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	akpm@...ux-foundation.org, clameter@....com,
	Lee.Schermerhorn@...com, ak@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [patch -mm 4/4] mempolicy: remove includes for duplicate
 headers

David R wrote:
> Remove #includes for:
> 
> 	linux/mempolicy.h	(already from linux/migrate.h)
> 	linux/mm.h		(already from linux/highmem.h)

I didn't see any problem offhand with the other patches 0 to 3 in this
set, but this patch 4/4 surprises me.

Perhaps I'm out of phase with what's customary in the kernel, but I
prefer directly including whatever headers I explicitly need.
Depending on some other header to drag in something you have explicit
need of anyway makes things more fragile.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.940.382.4214
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/