| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2008 12:51:11 -0800 (PST) From: David Rientjes <rientjes@...gle.com> To: Paul Jackson <pj@....com> cc: akpm@...ux-foundation.org, clameter@....com, Lee.Schermerhorn@...com, ak@...e.de, linux-kernel@...r.kernel.org Subject: Re: [patch -mm 4/4] mempolicy: remove includes for duplicate headers On Thu, 6 Mar 2008, Paul Jackson wrote: > > Remove #includes for: > > > > linux/mempolicy.h (already from linux/migrate.h) > > linux/mm.h (already from linux/highmem.h) > > I didn't see any problem offhand with the other patches 0 to 3 in this > set, but this patch 4/4 surprises me. > > Perhaps I'm out of phase with what's customary in the kernel, but I > prefer directly including whatever headers I explicitly need. > Depending on some other header to drag in something you have explicit > need of anyway makes things more fragile. > It simply decreases the remote chance later that we'll develop obscure header file dependencies for some archs like we saw with the memcontroller and the sparc build. There are no strange dependencies that I am currently aware of, so this is not a bugfix. The only way this would make things more fragile is if a header file removes an include for another header file without checking all the users of the former first and fixing it up in mm/mempolicy.c. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists