linux-kernel - Re: [PATCH] Add cgroup support for enabling controllers at boot time (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6599ad830803070125o1ebfd7d1r728cdadf726ecbe2@mail.gmail.com>
Date:	Fri, 7 Mar 2008 01:25:51 -0800
From:	"Paul Menage" <menage@...gle.com>
To:	"Balbir Singh" <balbir@...ux.vnet.ibm.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Pavel Emelianov" <xemul@...nvz.org>,
	"Hugh Dickins" <hugh@...itas.com>,
	"Sudhir Kumar" <skumar@...ux.vnet.ibm.com>,
	"YAMAMOTO Takashi" <yamamoto@...inux.co.jp>, lizf@...fujitsu.com,
	linux-kernel@...r.kernel.org, taka@...inux.co.jp,
	linux-mm@...ck.org, "David Rientjes" <rientjes@...gle.com>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH] Add cgroup support for enabling controllers at boot time (v2)

On Fri, Mar 7, 2008 at 12:57 AM, Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
>
>  This doesn't handle early_init subsystems (their "disabled" bit isn't
>  set be,

I think you meant something like

(their "disabled" bit isn't set before their initial "create" call is made)

>  +static int __init cgroup_disable(char *str)
>  +{
>  +       int i;
>  +
>  +       while (*str) {
>  +               for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
>  +                       struct cgroup_subsys *ss = subsys[i];
>  +
>  +                       if (!strncmp(str, ss->name, strlen(ss->name))) {
>  +                               ss->disabled = 1;
>  +                               printk(KERN_INFO "Disabling %s control group"
>  +                                       " subsystem\n", ss->name);
>  +                               break;

Doesn't this mean that cgroup_disable=cpu will disable whichever comes
first out of cpuset, cpuacct or cpu in the subsystem list?

I suggest just sticking with the original simpler version that
required separate cgroup_disabled=foo options for each system that you
want to disable.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/