[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a8e1da0803091903i3ea7a54bkea797a43eeae462e@mail.gmail.com>
Date: Mon, 10 Mar 2008 10:03:47 +0800
From: "Dave Young" <hidave.darkstar@...il.com>
To: "Andrew Morton" <akpm@...ux-foundation.org>
Cc: "Alan Cox" <alan@...rguk.ukuu.org.uk>,
"Johannes Weiner" <hannes@...urebad.de>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] add time_now_after and other macros which compare with jiffies
On Mon, Mar 10, 2008 at 3:01 AM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Sun, 9 Mar 2008 11:08:08 +0000 Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
>
> > > Yes, This has a purpose as well. You will find most of the usage of these
> > > macros are just compare some value with jiffies after doing some grep.
> >
> > That is no reason to add more macros that hide how they do it, or make
> > jiffies itself invisible to the grep search or variable usage finding
> > tools (and for tickless that very thing is important)
>
> We could call them time_is_after_jiffies(), time_is_before_jiffies(), etc.
>
> Those names are actually better than time_after_now(), etc.
>
>
Andrew, Hannes, Alan,
thanks for your comment, I have send the new time_is_* patch as v3.
Hannes, It's more like your is_past/is_future but looks better when
along with _eq
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists