linux-kernel - Re: [patch] fix ACPI boot regression (was: Re: Linux 2.6.25-rc5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080310172417.GA25898@elte.hu>
Date:	Mon, 10 Mar 2008 18:24:17 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Len Brown <lenb@...nel.org>
Subject: Re: [patch] fix ACPI boot regression (was: Re: Linux 2.6.25-rc5)


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Mon, 10 Mar 2008, Ingo Molnar wrote:
> >
> > so zero-extending the result in the PCI-BIOS read routine fixes the 
> > regression on my laptop. ( It might fix some other long-standing 
> > issues we had with PCI-BIOS during the past decade ... ) Both 8-bit 
> > and 16-bit accesses were buggy.
> 
> Oh, wow. That must have been there forever, but very few people 
> probably ever cared.
> 
> And why is your laptop using the BIOS routines anyway? Or was that 
> just a result of your randconfig having turned off the sane config 
> access routines?

yeah, randconfig generated this:

  CONFIG_PCI=y
  CONFIG_PCI_GOBIOS=y
  # CONFIG_PCI_GOMMCONFIG is not set
  # CONFIG_PCI_GODIRECT is not set
  # CONFIG_PCI_GOANY is not set
  CONFIG_PCI_BIOS=y

which forced the PCI code into the BIOS access method on this otherwise 
modern system. I disable some of the really-known-to-be-broken .config 
options in randconfig - but i still bravely keept CONFIG_GO_PCIBIOS in 
the randomized space, which triggered this.

On another box, which has a different BIOS, this bug never happened, in 
tens of thousands of bootup tests.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/