linux-kernel - Re: ADT746X: logical-bitwise & confusion in set_max_duty_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1dd996a5ad3a455c91886cacd3243128@kernel.crashing.org>
Date:	Mon, 10 Mar 2008 22:56:00 +0100
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	akpm@...ux-foundation.org, "Darrick J. Wong" <djwong@...ibm.com>,
	benh@...nel.crashing.org, linuxppc-dev@...abs.org,
	lkml <linux-kernel@...r.kernel.org>,
	Colin Leroy <colin@...ino.net>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()

> It includes suggested changes by Segher Boessenkool and I think this
> version was tested by Darrick J. Wong

> -	u8 reg;
> +	u8 reg, temp;
>  	struct i2c_client *client = to_i2c_client(dev);
>  	struct adt7473_data *data = i2c_get_clientdata(client);
> -	int temp = simple_strtol(buf, NULL, 10);
> -	temp = temp && 0xFF;
> +
> +	temp = simple_strtol(buf, NULL, 10) & 0xFF;

It still does this superfluous "& 0xff", which hides the lack of
range checking.


Segher

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/