linux-kernel - Re: ADT746X: logical-bitwise & confusion in set_max_duty_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Mar 2008 23:15:05 +0100
From:	Roel Kluin <12o3l@...cali.nl>
To:	Segher Boessenkool <segher@...nel.crashing.org>
CC:	akpm@...ux-foundation.org, "Darrick J. Wong" <djwong@...ibm.com>,
	benh@...nel.crashing.org, linuxppc-dev@...abs.org,
	lkml <linux-kernel@...r.kernel.org>,
	Colin Leroy <colin@...ino.net>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()

Segher Boessenkool wrote:
>> It includes suggested changes by Segher Boessenkool and I think this
>> version was tested by Darrick J. Wong
> 
>> -    u8 reg;
>> +    u8 reg, temp;
>>      struct i2c_client *client = to_i2c_client(dev);
>>      struct adt7473_data *data = i2c_get_clientdata(client);
>> -    int temp = simple_strtol(buf, NULL, 10);
>> -    temp = temp && 0xFF;
>> +
>> +    temp = simple_strtol(buf, NULL, 10) & 0xFF;
> 
> It still does this superfluous "& 0xff", which hides the lack of
> range checking.

Sorry didn't quite grep that
---
logical-bitwise & confusion

Signed-off-by: Roel Kluin <12o3l@...cali.nl>
---
diff --git a/drivers/hwmon/adt7473.c b/drivers/hwmon/adt7473.c
index 9587869..98937d3 100644
--- a/drivers/hwmon/adt7473.c
+++ b/drivers/hwmon/adt7473.c
@@ -566,11 +566,11 @@ static ssize_t set_max_duty_at_crit(struct device *dev,
 				    const char *buf,
 				    size_t count)
 {
-	u8 reg;
+	u8 reg, temp;
 	struct i2c_client *client = to_i2c_client(dev);
 	struct adt7473_data *data = i2c_get_clientdata(client);
-	int temp = simple_strtol(buf, NULL, 10);
-	temp = temp && 0xFF;
+
+	temp = simple_strtol(buf, NULL, 10);
 
 	mutex_lock(&data->lock);
 	data->max_duty_at_overheat = temp;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/