linux-kernel - Re: [PATCH 2/3] gpiolib: implement gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200803121559.13342.david-b@pacbell.net>
Date:	Wed, 12 Mar 2008 14:59:12 -0800
From:	David Brownell <david-b@...bell.net>
To:	avorontsov@...mvista.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] gpiolib: implement gpiochip_reserve

On Wednesday 12 March 2008, Anton Vorontsov wrote:
> > It
> > presumes the reserved bits and gpio chips are in fairly
> > close synch.
> 
> Probably I don't understand the synch part here. The thing is that
> I'm replacing if (!chip) with if (!chip && !test_bit(FLAG_RESERVED,
> &desc->flags)), so now "else" code might be executed when gpio is
> either reserved or the range of gpios is already managed by the chip.

OK then.


> Below the patch with __init attribute added.
> 
> - - - -
> From: Anton Vorontsov <avorontsov@...mvista.com>
> Subject: gpiolib: implement gpiochip_reserve
> 
> Function gpiochip_reserve() reserves range of gpios to use with
> platform code only, that is, this function used to mark specified
> range of gpios unavailable for the dynamic gpio base allocator.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>

> ---
>  ...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/