[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1205401732.26537.43.camel@localhost>
Date: Thu, 13 Mar 2008 10:48:52 +0100
From: Martin Schwidefsky <schwidefsky@...ibm.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
heiko.carstens@...ibm.com
Subject: Re: [patch 03/10] sched: add exported arch_reinit_sched_domains()
to header file.
On Wed, 2008-03-12 at 16:03 -0700, Andrew Morton wrote:
> > +#if defined(CONFIG_SCHED_MC) || defined(CONFIG_SCHED_SMT)
> > +extern int arch_reinit_sched_domains(void);
> > +#endif
>
> I tend to recommend that the ifdefs be omitted here.
>
> It has the downside that the build will then fail at link-time rather than
> at compile-time, but I haven't seen anyone complain about that.
Ok, I've removed the #if.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists