lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Mar 2008 11:02:55 +0100 From: Martin Schwidefsky <schwidefsky@...ibm.com> To: "Josef 'Jeff' Sipek" <jeffpc@...efsipek.net> Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org Subject: Re: [patch 01/10] Add new fields for System z10 to /proc/sysinfo On Wed, 2008-03-12 at 13:57 -0400, Josef 'Jeff' Sipek wrote: > > Index: quilt-2.6/drivers/s390/sysinfo.c > > =================================================================== > > --- quilt-2.6.orig/drivers/s390/sysinfo.c > > +++ quilt-2.6/drivers/s390/sysinfo.c > > @@ -26,6 +26,11 @@ struct sysinfo_1_1_1 { > > char sequence[16]; > > char plant[4]; > > char model[16]; > > + char model_perm_cap[16]; > > + char model_temp_cap[16]; > > + char model_cap_rating[4]; > > + char model_perm_cap_rating[4]; > > + char model_temp_cap_rating[4]; > > }; > > I'd try to be safer, and make the struct __attribute__((packed))... Hmm, that would be true for all sysinfo typedefs. The automatic alignment does the right thing though. Don't know if its worth the effort - at least until you get bitten for the first time ;-) -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists