linux-kernel - [PATCH] THERMAL must not select HWMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080314183758.GA15028@wavehammer.waldi.eu.org>
Date:	Fri, 14 Mar 2008 19:37:58 +0100
From:	Bastian Blank <bastian@...di.eu.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, Zhang Rui <rui.zhang@...el.com>
Subject: [PATCH] THERMAL must not select HWMON

On Fri, Mar 14, 2008 at 11:21:12AM -0700, Randy Dunlap wrote:

[ select forces HWMON to yes even if deps are never applicable ]

> Yes, that's a known & longstanding problem (that select does not
> follow/honor dependencies).

Okay.

So THERMAL can't select HWMON, instead it needs to do a proper depends.

Bastian

Signed-off-by: Bastian Blank <waldi@...ian.org>
Cc: Zhang Rui <rui.zhang@...el.com>

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 3ab313e..394912c 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -4,7 +4,7 @@
 
 menuconfig THERMAL
 	bool "Generic Thermal sysfs driver"
-	select HWMON
+	depends on HWMON
 	default y
 	help
 	  Generic Thermal Sysfs driver offers a generic mechanism for
-- 
You canna change the laws of physics, Captain; I've got to have thirty minutes!

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)