linux-kernel - Re: [PATCH] sched: fix race in schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b647ffbd0803141547s55fa37a1j5af4e50388d3117f@mail.gmail.com>
Date:	Fri, 14 Mar 2008 23:47:05 +0100
From:	"Dmitry Adamushko" <dmitry.adamushko@...il.com>
To:	"Hiroshi Shimamoto" <h-shimamoto@...jp.nec.com>
Cc:	"Peter Zijlstra" <peterz@...radead.org>,
	"Ingo Molnar" <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	linux-rt-users@...r.kernel.org, hpj@...la.net,
	stable <stable@...nel.org>
Subject: Re: [PATCH] sched: fix race in schedule

On 14/03/2008, Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:
>
> [ ... ]
>
>  >> But maybe there is something esle that would be exposed by the
>  >> 'rq->curr = rq->idle' manipulation... I can't provide examples right
>  >> now though (I need to think on it).
>  >
>  > I share your concerns, I don't really like it either. Just spewing out
>  > ideas here - bad ideas it seems :-/
>  >
>  > Ingo also suggested moving the balance calls right before
>  > deactivate_task(), but that gives a whole other set of head-aches.
>  >
>
>
> Well, what will we do about this issue?
>  I see you're thinking to fix inconsistency in scheduler, right?
>  I agree about it.
>
>  However, I don't think it's good to remain this issue long time in
>  the -stable kernel.
>
>  Could you please let me know what I can do?

IMHO, the safest solution for the time being (and esp. for -stable)
would be to proceed with Hiroshi's patch. It looks safe and it does
fix a real problem.


>
> Hiroshi Shimamoto
>

-- 
Best regards,
Dmitry Adamushko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/