linux-kernel - Re: [PATCH 4/5] ntp.c code flow clenaups (from Ingo)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0803151823380.1791@scrub.home>
Date:	Sat, 15 Mar 2008 18:24:18 +0100 (CET)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Ingo Oeser <ingo.oeser@...eria.de>
cc:	john stultz <johnstul@...ibm.com>,
	lkml <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 4/5]  ntp.c code flow clenaups  (from Ingo)

Hi,

On Sat, 15 Mar 2008, Ingo Oeser wrote:

> I don't understand, why the goto is required here. 
> 
> If you move these two cases in front of case "TIME_OK" and
> omit the break, you can remove the goto and the label "start_timer".
> Don't forget the /* fall through */ comment then.

Nice catch, I'll do this in the original patch.

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/