linux-kernel - Re: [PATCH] de-semaphorize smackfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080318073503.GA25958@infradead.org>
Date:	Tue, 18 Mar 2008 03:35:03 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jonathan Corbet <corbet@....net>
Cc:	linux-kernel@...r.kernel.org,
	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH] de-semaphorize smackfs

On Mon, Mar 17, 2008 at 05:14:40PM -0600, Jonathan Corbet wrote:
> While looking at the generic semaphore patch, I came to wonder what the
> remaining semaphore users in the kernel were actually doing.  After a
> quick grep for down_interruptible(), smackfs remained at the bottom of
> my screen.  It seems like a straightforward mutex case - low-hanging
> fruit.  So here's a conversion patch; compile-tested only, but what
> could go wrong?

The lock is kept while returning to userspace and could potentially
be release by another process.  This is not allowed for mutexes.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/