[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080318072802.GH6091@localdomain>
Date: Tue, 18 Mar 2008 00:28:02 -0700
From: Ravikiran Thirumalai <kiran@...lemp.com>
To: Yinghai Lu <yhlu.kernel@...il.com>
Cc: linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
gcosta@...hat.com, mingo@...e.hu, tglx@...utronix.de
Subject: Re: + x86-vsmp-build-fixes.patch added to -mm tree
On Mon, Mar 17, 2008 at 10:26:55PM -0700, Yinghai Lu wrote:
>On Mon, Mar 17, 2008 at 10:14 PM, <akpm@...ux-foundation.org> wrote:
>> ...
>> Subject: x86: vsmp build fixes
>> From: Glauber Costa <gcosta@...hat.com>
>>
>> VSMP depends on PCI, but the file is now compiled conditionally on PARAVIRT,
>> no VSMP, so enclose everything in an ifdef CONFIG_PCI.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
>
>in arch/x86/Kconfig
>
>config PCI
> bool "PCI support" if !X86_VISWS && !X86_VSMP
> depends on !X86_VOYAGER
> default y
> select ARCH_SUPPORTS_MSI if (X86_LOCAL_APIC && X86_IO_APIC)
> help
> Find out whether you have a PCI motherboard. PCI is the name of a
> bus system, i.e. the way the CPU talks to the other stuff inside
> your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
> VESA. If you have PCI, say Y, otherwise N.
>
>will make sure if X86_VSMP, the PCI=y
>
>so NAK this patch.
>
Not really, as you can tell from the description Glauber provided above.
Btw, I had something similar to this cooking for the build breakage, along
with a few more updates (is_vsmp_box() is broken on vsmp). Thanks Glauber
for this patch.
Thanks,
Kiran
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists