[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <86802c440803180056i4d3a7029n6f4d07f3ca5763ee@mail.gmail.com>
Date: Tue, 18 Mar 2008 00:56:59 -0700
From: "Yinghai Lu" <yhlu.kernel@...il.com>
To: "Ravikiran Thirumalai" <kiran@...lemp.com>,
"Andrew Morton" <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
gcosta@...hat.com, mingo@...e.hu, tglx@...utronix.de
Subject: Re: + x86-vsmp-build-fixes.patch added to -mm tree
On Tue, Mar 18, 2008 at 12:28 AM, Ravikiran Thirumalai
<kiran@...lemp.com> wrote:
> On Mon, Mar 17, 2008 at 10:26:55PM -0700, Yinghai Lu wrote:
> >On Mon, Mar 17, 2008 at 10:14 PM, <akpm@...ux-foundation.org> wrote:
> >> ...
>
> >> Subject: x86: vsmp build fixes
> >> From: Glauber Costa <gcosta@...hat.com>
> >>
> >> VSMP depends on PCI, but the file is now compiled conditionally on PARAVIRT,
> >> no VSMP, so enclose everything in an ifdef CONFIG_PCI.
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> ...
>
> >
> >in arch/x86/Kconfig
> >
> >config PCI
> > bool "PCI support" if !X86_VISWS && !X86_VSMP
> > depends on !X86_VOYAGER
> > default y
> > select ARCH_SUPPORTS_MSI if (X86_LOCAL_APIC && X86_IO_APIC)
> > help
> > Find out whether you have a PCI motherboard. PCI is the name of a
> > bus system, i.e. the way the CPU talks to the other stuff inside
> > your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
> > VESA. If you have PCI, say Y, otherwise N.
> >
> >will make sure if X86_VSMP, the PCI=y
> >
> >so NAK this patch.
> >
>
> Not really, as you can tell from the description Glauber provided above.
oh, you mean PARAVIRT is defined, but VSMP is not used ?
then that patch is OK, but it is some ugly... or you can split that file?
>
> Btw, I had something similar to this cooking for the build breakage, along
> with a few more updates (is_vsmp_box() is broken on vsmp). Thanks Glauber
> for this patch.
>
that is funny, i just extracted is_vsmp_box from vsmp_init...
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists