linux-kernel - Re: ide_cd modifies hard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ea470500803180405h5ede15eaqa86515058a632e2b@mail.gmail.com>
Date:	Tue, 18 Mar 2008 12:05:14 +0100
From:	"Boris Petkov" <petkovbb@...glemail.com>
To:	"Nikanth Karthikesan" <knikanth@...e.de>
Cc:	"Jens Axboe" <jens.axboe@...cle.com>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: ide_cd modifies hard_* members of request

(sorry, forgot to cc all)

On Tue, Mar 18, 2008 at 9:54 AM, Nikanth Karthikesan <knikanth@...e.de> wrote:
> Hi
>
>  Despite the warning in blkdev.h, that members of struct request starting
>  with hard_* are block layer internals, and no driver should touch them,
>  the ide_cd driver seems to fiddle around with it.
>
>  Is this reqd, or can this be made to work without the need for this?
>
>  If this reqd, why not provide a helper function for that in block layer
>  itself, may be, with a warning about usage?
>
>  Thanks
>  Nikanth Karthikesan

Hi,

the code pieces you're referring to are in there since at least the
first git import of the kernel source (i.e. 2005) aka long time so
Bart/Jens should know that...


-- 
Regards/Gruß,
Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/