[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080318110803.GV17940@kernel.dk>
Date: Tue, 18 Mar 2008 12:08:04 +0100
From: Jens Axboe <jens.axboe@...cle.com>
To: petkovbb@...il.com
Cc: Nikanth Karthikesan <knikanth@...e.de>,
Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: ide_cd modifies hard_* members of request
On Tue, Mar 18 2008, Boris Petkov wrote:
> (sorry, forgot to cc all)
>
> On Tue, Mar 18, 2008 at 9:54 AM, Nikanth Karthikesan <knikanth@...e.de> wrote:
> > Hi
> >
> > Despite the warning in blkdev.h, that members of struct request starting
> > with hard_* are block layer internals, and no driver should touch them,
> > the ide_cd driver seems to fiddle around with it.
> >
> > Is this reqd, or can this be made to work without the need for this?
> >
> > If this reqd, why not provide a helper function for that in block layer
> > itself, may be, with a warning about usage?
> >
> > Thanks
> > Nikanth Karthikesan
>
> Hi,
>
> the code pieces you're referring to are in there since at least the
> first git import of the kernel source (i.e. 2005) aka long time so
> Bart/Jens should know that...
restore_request(), I'm assuming. It was probably me who modified this
code, I don't think there's any justification for it. I would suggest
killing it. And cdrom_read_from_buffer() as well, it's a silly addition.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists