linux-kernel - Re: [PATCH]CHECKPATCH:fix misleading output on spaces/tabs error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080319141355.GC8590@shadowen.org>
Date:	Wed, 19 Mar 2008 14:13:55 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Daolong Wang <ahlongxp@...il.com>
Cc:	linux-kernel@...r.kernel.org, rdunlap@...otime.net,
	jschopp@...tin.ibm.com
Subject: Re: [PATCH]CHECKPATCH:fix misleading output on spaces/tabs error

On Wed, Mar 19, 2008 at 11:06:02AM +0800, Daolong Wang wrote:
> I got confused by this line:
> 
>     "ERROR: use tabs not spaces"
> 
> It literally means "use tabs but not spaces is WRONG", which
>  is WRONG.
> 
>     "ERROR: do not use spaces when tabs expected"
> 
> sounds more appropriate.

Except that it says "use tabs not spaces when you should use tabs" and
doesn't actually tell us what the error was, nor how to correct it.  So
its not really any better than the original (which is also useless in
this regard).

How about:

	"code indent should use tabs where possible"

> Signed-off-by: Wang Daolong <ahlongxp@...il.com>
> ---
> --- scripts/checkpatch.pl.org	2008-03-18 23:08:41.000000000 +0800
> +++ scripts/checkpatch.pl	2008-03-18 23:19:34.000000000 +0800
> @@ -1064,7 +1064,7 @@ sub process {
>  		if ($rawline =~ /^\+\s* \t\s*\S/ ||
>  		    $rawline =~ /^\+\s*        \s*/) {
>  			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> -			ERROR("use tabs not spaces\n" . $herevet);
> +			ERROR("do not use spaces when tabs expected\n" . $herevet);
>  		}
> 
>  # check for RCS/CVS revision markers

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/