linux-kernel - [PATCH]CHECKPATCH:fix misleading output on spaces/tabs error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc84318c0803182006u46b4ac2aj8d7a127963a0d5f3@mail.gmail.com>
Date:	Wed, 19 Mar 2008 11:06:02 +0800
From:	"Daolong Wang" <ahlongxp@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	apw@...dowen.org, rdunlap@...otime.net, jschopp@...tin.ibm.com
Subject: [PATCH]CHECKPATCH:fix misleading output on spaces/tabs error

I got confused by this line:

    "ERROR: use tabs not spaces"

It literally means "use tabs but not spaces is WRONG", which
 is WRONG.

    "ERROR: do not use spaces when tabs expected"

sounds more appropriate.

Signed-off-by: Wang Daolong <ahlongxp@...il.com>
---
--- scripts/checkpatch.pl.org	2008-03-18 23:08:41.000000000 +0800
+++ scripts/checkpatch.pl	2008-03-18 23:19:34.000000000 +0800
@@ -1064,7 +1064,7 @@ sub process {
 		if ($rawline =~ /^\+\s* \t\s*\S/ ||
 		    $rawline =~ /^\+\s*        \s*/) {
 			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
-			ERROR("use tabs not spaces\n" . $herevet);
+			ERROR("do not use spaces when tabs expected\n" . $herevet);
 		}

 # check for RCS/CVS revision markers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/