linux-kernel - Re: [PATCH] build fix for smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080319195217.GA20762@elte.hu>
Date:	Wed, 19 Mar 2008 20:52:17 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	tglx@...utronix.de, ak@...e.de
Subject: Re: [PATCH] build fix for smp

* Glauber de Oliveira Costa <gcosta@...hat.com> wrote:

> +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_BIOS_REBOOT)
>  	if (reboot_force)
>  		return;
> +#endif

please solve it slightly differently: introduce a uniformly usable 
reboot_force flag, that will always default to the constant of 1 if 
!X86_64 && !X86_BIOS_REBOOT. That makes the code cleaner - and not the 
least i can also merge the fix earlier in the series, without having to 
redo the big smp.c movement patch :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/