linux-kernel - Re: [PATCH 1/3] Infiniband: make ehca_pd use struct pid pointer rather than pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adazlsvopl7.fsf@cisco.com>
Date:	Tue, 18 Mar 2008 11:27:00 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Hoang-Nam Nguyen <HNGUYEN@...ibm.com>
Cc:	Christoph Raisch <raisch@...ibm.com>,
	general@...ts.openfabrics.org,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Roland Dreier <rolandd@...co.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Pavel Emelyanov <xemul@...nvz.org>
Subject: Re: [PATCH 1/3] Infiniband: make ehca_pd use struct pid pointer rather than pid_t

 > Right, above checking is based on a very simple policy "creator of a
 > resource is also the owner in term of releasing it" and will not cover
 > other customized patterns. We had a case - believe on sles9, in which
 > a child process manipulated/released resources from parent one, and
 > it was not easy to find the bug.

Hmm, I can see how that might be ugly.  On the other hand it doesn't
seem like the unix way for a process not to be able to do something
with a file if it has a valid fd.

 > Wrt/ your actual question: we can remove the tgid stuff from ehca kernel
 > code. When do you expect me to send a patch at latest?

I don't think it's super-urgent.  If you can't do it, say, by the end
of this week, then I'll apply Pavel's patch so we don't block his
progress on namespace stuff.  But I would still like to get a patch to
move this out of ehca at some point, so please don't drop it.

If you guys think there is value in having the checks, then please
send a patch to add the ownership stuff to the uverbs core and we can
argue about it then.

Thanks,
  Roland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/