linux-kernel - Re: [PATCH] signals: check_kill_permission: check session under tasklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080318201725.GA92@tv-sign.ru>
Date:	Tue, 18 Mar 2008 23:17:25 +0300
From:	Oleg Nesterov <oleg@...sign.ru>
To:	serge@...lyn.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Atsushi Tsuji <a-tsuji@...jp.nec.com>,
	Roland McGrath <roland@...hat.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Davide Libenzi <davidel@...ilserver.org>,
	Ingo Molnar <mingo@...e.hu>, Jiri Kosina <jkosina@...e.cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pavel Emelyanov <xemul@...nvz.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signals: check_kill_permission: check session under tasklist_lock

On 03/18, serge@...lyn.com wrote:
>
> Quoting Oleg Nesterov (oleg@...sign.ru):
> > --- 25/security/commoncap.c~CKP_TAKE_TASKLIST	2008-03-18 17:07:02.000000000 +0300
> > +++ 25/security/commoncap.c	2008-03-18 17:21:10.000000000 +0300
> > @@ -552,10 +552,6 @@ int cap_task_kill(struct task_struct *p,
> >  	if (p->uid == current->uid)
> >  		return 0;
> >  
> > -	/* sigcont is permitted within same session */
> > -	if (sig == SIGCONT && (task_session_nr(current) == task_session_nr(p)))
> > -		return 0;
> > -
> >  	if (secid)
> >  		/*
> >  		 * Signal sent as a particular user.
> 
> Note that cap_task_kill() should be gone anyway.  What tree were you
> basing this on?

Ah. I realy hoped that cap_task_kill() was already killed. And I googled
this patch: http://marc.info/?l=linux-kernel&m=120422062515386

But I checked 2.6.25-rc5-mm1.bz2, it is still here. And I didn't find
anything related in http://userweb.kernel.org/~akpm/mmotm/. I even checked
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=security/commoncap.c

So, is it still here or killed? If it is dead - great ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/