linux-kernel - Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080319153946.a5a8060e.akpm@linux-foundation.org>
Date:	Wed, 19 Mar 2008 15:39:46 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Jaya Kumar" <jayakumar.lkml@...il.com>
Cc:	armbru@...hat.com, linux-kernel@...r.kernel.org,
	virtualization@...ts.osdl.org, xen-devel@...ts.xensource.com,
	linux-fbdev-devel@...ts.sourceforge.net, adaplas@....net,
	linux-input@...r.kernel.org, dmitry.torokhov@...il.com
Subject: Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

On Thu, 20 Mar 2008 06:30:37 +0800
"Jaya Kumar" <jayakumar.lkml@...il.com> wrote:

> On Thu, Mar 20, 2008 at 2:37 AM, Andrew Morton
> <akpm@...ux-foundation.org> wrote:
> >
> >  Do we need some of all of that patch in 2.6.25?  I wasn't aware of such a
> >  need.
> >
> >  If the drivers/video/fb_defio.c hunk of that patch fixes something then I'd
> >  be inclined to merge the whole thing - adding a new driver won't hurt
> >  anyone.
> >
> 
> Yes, the defio hunk is a bugfix. I agree with pushing the whole thing
> to 2.6.25 if there are people who need it in 2.6.25. I believe there
> is no risk of impact on anyone else.
> 

Well all we have in the changelog is

  Implement support for the E-Ink Metronome controller.  It provides an
  mmapable interface to the controller using defio support.  It was tested
  with a gumstix pxa255 with Vizplex media using Xfbdev and various X
  clients such as xeyes, xpdf, xloadimage.

grump.  This say nothing at all about the change to drivers/video/fb_defio.c.

a) the changelog _should_ document this change.  Please send a paragraph and
   I'll add it.

b) If this discussion hadn't happened, that bug (whatever it is) would
   have remained unfixed in 2.6.25.  As a direct consequence of poor
   changelogging.

c) This bugfix (whatever it is) should have been in a separate patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/