linux-kernel - Re: [PATCH 14/17] ide-tape: remove pipeline-specific members from struct ide_tape

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2008 01:09:47 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Borislav Petkov <petkovbb@...glemail.com>
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Borislav Petkov <petkovbb@...il.com>
Subject: Re: [PATCH 14/17] ide-tape: remove pipeline-specific members from struct ide_tape_obj

On Monday 17 March 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <petkovbb@...il.com>

applied after:
- merging with "ide-tape: remove pipeline-specific code from idetape_setup"
- cleaning up __idetape_discard_read_pipeline() (since patch #3 was dropped)
- cleaning up idetape_empty_write_pipeline() (since patch #4 was dropped)

> @@ -1905,7 +1855,6 @@ static int idetape_blkdev_ioctl(ide_drive_t *drive, unsigned int cmd,
>  	struct idetape_config {
>  		int dsc_rw_frequency;
>  		int dsc_media_access_frequency;
> -		int nr_stages;

we need to keep it:

>  	} config;
>  
>  	debug_log(DBG_PROCS, "Enter %s\n", __func__);
> @@ -1915,11 +1864,9 @@ static int idetape_blkdev_ioctl(ide_drive_t *drive, unsigned int cmd,
>  		if (copy_from_user(&config, argp, sizeof(config)))
>  			return -EFAULT;
>  		tape->best_dsc_rw_freq = config.dsc_rw_frequency;
> -		tape->max_stages = config.nr_stages;
>  		break;
>  	case 0x0350:
>  		config.dsc_rw_frequency = (int) tape->best_dsc_rw_freq;
> -		config.nr_stages = tape->max_stages;

changed this to export '1' to user-space
(which has always meant that pipeline-mode is disabled)

>  		if (copy_to_user(argp, &config, sizeof(config)))
>  			return -EFAULT;
>  		break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/