linux-kernel - Re: [PATCH] Subject: kprobes-x86: correct post-eip value in post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080321110804.GY20420@elte.hu>
Date:	Fri, 21 Mar 2008 12:08:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yakov Lerner <iler.ml@...il.com>
Cc:	prasanna@...ibm.com, ananth@...ibm.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net,
	linux-kernel@...r.kernel.org,
	Masami Hiramatsu <mhiramat@...hat.com>
Subject: Re: [PATCH] Subject: kprobes-x86: correct post-eip value in
	post_hander()


* Yakov Lerner <iler.ml@...il.com> wrote:

> I was trying to get the address of instruction to be executed next 
> after the kprobed instruction.  But regs->eip in post_handler() 
> contains value which is useless to the user. It's pre-corrected value. 
> This value is difficult to use without access to resume_execution(), 
> which is not exported anyway. I moved the invocation of post_handler() 
> to *after* resume_execution(). Now regs->eip contains meaningful value 
> in post_handler().
> 
> I do not think this change breaks any backward-compatibility. To make 
> meaning of the old value, post_handler() would need access to 
> resume_execution() which is not exported.  I have difficulty to 
> believe that previous, uncorrected, regs->eip can be meaningfully used 
> in post_handler().

thanks, i've added your patch to the .26 bucket of x86.git, but it would 
be nice to get an Ack/Nack from a kprobes person as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/