linux-kernel - Re: [PATCH] Arch: x86_32, fix fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080321115029.GB25225@elte.hu>
Date:	Fri, 21 Mar 2008 12:50:29 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] Arch: x86_32, fix fault_msg nul termination


* Jiri Slaby <jirislaby@...il.com> wrote:

> The fault_msg text is not explictly nul terminated now in startup 
> assembly. Do so by converting .ascii to .asciz.

thanks Jiri, applied.

>  fault_msg:
> -	.ascii								\
> +	.asciz								\
>  /* fault info: */	"BUG: Int %d: CR2 %p\n"				\
>  /* pusha regs: */	"     EDI %p  ESI %p  EBP %p  ESP %p\n"		\
>  			"     EBX %p  EDX %p  ECX %p  EAX %p\n"		\

i guess in practice we were saved by a NIL following this string, but 
there's no guarantee indeed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/