[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080321104125.e1ff69c5.akpm@linux-foundation.org>
Date: Fri, 21 Mar 2008 10:41:25 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Rodolfo Giometti <giometti@...eenne.com>
Cc: linux-kernel@...r.kernel.org, dwmw2@...radead.org,
davej@...hat.com, sam@...nborg.org, greg@...ah.com,
randy.dunlap@...cle.com
Subject: Re: [PATCH 5/7] PPS: serial clients support.
On Fri, 21 Mar 2008 12:17:36 +0100 Rodolfo Giometti <giometti@...eenne.com> wrote:
> > > +#else
> > > +
> > > +#define uart_register_pps_port(state, port) do { } while (0)
> > > +#define uart_unregister_pps_port(state, port) do { } while (0)
> >
> > Please never implement in cpp that which can be implemented in C. These
> > should have been static inlines. That's nicer, matches the
> > CONFIG_PPS_CLIENT_UART=y code and provides type checking.
>
> Are you saying that I should do:
>
> static inline int
> uart_register_pps_port(struct uart_state *state, struct uart_port *port)
> {
> /* Nop */
> }
>
> static inline void
> uart_unregister_pps_port(struct uart_state *state, struct uart_port *port)
> {
> /* Nop */
> }
>
> ?
Yes please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists