linux-kernel - Re: [PATCH 5/7] PPS: serial clients support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Mar 2008 11:38:23 +0100
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, dwmw2@...radead.org,
	davej@...hat.com, sam@...nborg.org, greg@...ah.com,
	randy.dunlap@...cle.com
Subject: Re: [PATCH 5/7] PPS: serial clients support.

On Fri, Mar 21, 2008 at 10:41:25AM -0700, Andrew Morton wrote:
> On Fri, 21 Mar 2008 12:17:36 +0100 Rodolfo Giometti <giometti@...eenne.com> wrote:
> 
> > > > +#else
> > > > +
> > > > +#define uart_register_pps_port(state, port)	do { } while (0)
> > > > +#define uart_unregister_pps_port(state, port)	do { } while (0)
> > > 
> > > Please never implement in cpp that which can be implemented in C.  These
> > > should have been static inlines.  That's nicer, matches the
> > > CONFIG_PPS_CLIENT_UART=y code and provides type checking.
> > 
> > Are you saying that I should do:
> > 
> > static inline int
> > uart_register_pps_port(struct uart_state *state, struct uart_port *port)
> > {
> > 	/* Nop */
> > }
> > 
> > static inline void
> > uart_unregister_pps_port(struct uart_state *state, struct uart_port *port)
> > {
> > 	/* Nop */
> > }
> > 
> > ?
> 
> Yes please.

Fixed. I'll send a new patch ASAP.

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@...eenne.com
Linux Device Driver                             giometti@...dd.com
Embedded Systems                     		giometti@...ux.it
UNIX programming                     phone:     +39 349 2432127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/