linux-kernel - Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported regressions from 2.6.24)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47E5815B.4080002@kernel.org>
Date:	Sat, 22 Mar 2008 14:59:55 -0700
From:	"H. Peter Anvin" <hpa@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Thomas Meyer <thomas@...3r.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>
Subject: Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported
 regressions from 2.6.24)

Linus Torvalds wrote:
> 
> Ingo/Thomas - should ioremap*() perhaps take "resource_size_t" or a "u64" 
> for the address (and then "__ioremap()" should probably take a PFN, not a 
> physical address, and that one can remain just a "unsigned long"?)
> 

resource_size_t seems to make sense here.  In the case when we have 
64-bit resources but no PAE support we should error our when the 
resource is out of range rather than silently fail.

> Has anybody ever had a working 64-bit BAR on x86? Ivan? Maybe I'm missing 
> something..

64-bit BAR, certainly.  64-bit BAR with a value beyond 4 GB I would find 
questionable at best... I suspect the answer is "no".

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/