linux-kernel - Re: [PATCH] firewire: fw-ohci: catch self_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47E5D0F5.50101@redhat.com>
Date:	Sat, 22 Mar 2008 23:39:33 -0400
From:	Jarod Wilson <jwilson@...hat.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: fw-ohci: catch self_id_count == 0

Stefan Richter wrote:
> Stefan Richter wrote:
>> fw_core_handle_bus_reset() incorrectly relied on the assumption that
>> self_id_count > 0.
> 
> Even though
>     firewire: insist on successive self ID complete events
>     firewire: fw-ohci: add self ID error check
>     firewire: fw-ohci: catch self_id_count == 0
> didn't fix any of Jarod's weird setups, I plan on submitting these 
> patches nevertheless (after 2.6.25) because they IMO fix real 
> possibilities for panics in the topology code.

Agreed, they all looked valid and didn't cause any regressions in my own 
prodding. So go ahead with all three:

Signed-off-by: Jarod Wilson <jwilson@...hat.com>

-- 
Jarod Wilson
jwilson@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/