linux-kernel - Re: checkpatch [was: include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080324151258.GE2899@logfs.org>
Date:	Mon, 24 Mar 2008 16:12:59 +0100
From:	Jörn Engel <joern@...fs.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>, viro@...IV.linux.org.uk,
	joe@...ches.com, mingo@...e.hu, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: checkpatch [was: include/asm-x86/serial.h: checkpatch cleanups - formatting only]

On Mon, 24 March 2008 09:09:00 +0100, Jiri Slaby wrote:
> 
> Understand you points, but most of it is strict implementation of 
> CodingStyle. People, who don't prefer coding style as described in that 
> document, won't like checkpatch either.

I used to like CodingStyle.  Recently I've started to have doubts.
Basically, the file used to contain roughly this paraphrase:
"I know coding style is highly personly, but when possible I'd prefer to
 receive patches in this style..."

Over time the particular style has been refined more and more and the
tone of the document became a little more like:
"And the Lord sayeth, thou shalt not diverge from His style."

And that is just going too far.  Keeping the style roughly similar is
useful.  Several of the rules in CodingStyle are about writing code in a
way that avoids bugs.  Clearly useful.  But if you go too far you end in
religious zealotry.

Finding the right balance between following common rules and bending
them where appropriate is important - here as much as anywhere.

Jörn

-- 
The grand essentials of happiness are: something to do, something to
love, and something to hope for.
-- Allan K. Chalmers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/