linux-kernel - Re: checkpatch [was: include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Mar 2008 16:28:50 +0000
From:	"Will Newton" <will.newton@...il.com>
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	"Jiri Slaby" <jirislaby@...il.com>,
	"David Miller" <davem@...emloft.net>, viro@...iv.linux.org.uk,
	joe@...ches.com, mingo@...e.hu, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: checkpatch [was: include/asm-x86/serial.h: checkpatch cleanups - formatting only]

On 23 Mar 2008 18:36:21 +0100, Andi Kleen <andi@...stfloor.org> wrote:

>  Also checkpatch.pl --file seems to be a good candidate for one
>  of the worst ideas ever merged (to be fair it was difficult
>  to see it would become that bad in advance -- but it got)

I have found checkpatch --file useful when taking large amounts of out
of tree code (a kernel arch subdir and a number of drivers) and trying
to get them into better shape for inclusion. In that situation it's
quite a good way of seeing how far off that goal I am. Running it on
existing in-tree code is more problematic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/