linux-kernel - Re: [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31e679430803250258u3bb8b29esb5fa5f7d435674b8@mail.gmail.com>
Date:	Tue, 25 Mar 2008 11:58:40 +0200
From:	"Felipe Balbi" <felipebalbi@...rs.sourceforge.net>
To:	"Carlos Aguiar" <carlos.aguiar@...t.org.br>
Cc:	"Pierre Ossman" <drzeus-list@...eus.cx>,
	"Tony Lindgren" <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver

On Fri, Mar 14, 2008 at 9:36 PM, Carlos Aguiar
<carlos.aguiar@...t.org.br> wrote:
> From: Carlos Eduardo Aguiar <carlos.aguiar@...t.org.br>
>
>  This patch removes some opcodes from host driver so there's no need on putting
>  '#include <linux/mmc/mmc.h>', that should not be needed in host drivers.
>

You should update this patch and remove the '#include
<linux/mmc/mmc.h>' from omap.c

>  Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@...t.org.br>
>  ---
>   drivers/mmc/host/omap.c |   11 +++--------
>   1 files changed, 3 insertions(+), 8 deletions(-)
>
>  diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
>  index c9dfeb1..eb7175a 100644
>  --- a/drivers/mmc/host/omap.c
>  +++ b/drivers/mmc/host/omap.c
>  @@ -495,15 +495,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
>                 if (status & OMAP_MMC_STAT_CMD_TOUT) {
>                         /* Timeouts are routine with some commands */
>                         if (host->cmd) {
>  -                               if (host->cmd->opcode != MMC_ALL_SEND_CID &&
>  -                                               host->cmd->opcode !=
>  -                                               MMC_SEND_OP_COND &&
>  -                                               host->cmd->opcode !=
>  -                                               MMC_APP_CMD &&
>  -                                               !mmc_omap_cover_is_open(host))
>  +                               if (!mmc_omap_cover_is_open(host))
>                                         dev_err(mmc_dev(host->mmc),
>  -                                               "command timeout, CMD %d\n",
>  -                                               host->cmd->opcode);
>  +                                       "command timeout, CMD %d\n",
>  +                                       host->cmd->opcode);
>                                 host->cmd->error = -ETIMEDOUT;
>                                 end_command = 1;
>                         }
>  -- 1.5.3.GIT
>
>  --
>  To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>  the body of a message to majordomo@...r.kernel.org
>  More majordomo info at  http://vger.kernel.org/majordomo-info.html
>  Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Best Regards,

Felipe Balbi
felipebalbi@...rs.sourceforge.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/