linux-kernel - Re: [PATCH][RESEND] wireless: convert !X & Y to !(X & Y) in iwl4965_is_fat_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080325174227.GB3026@tuxdriver.com>
Date:	Tue, 25 Mar 2008 13:42:27 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	"Chatre, Reinette" <reinette.chatre@...el.com>
Cc:	Roel Kluin <12o3l@...cali.nl>, "Zhu, Yi" <yi.zhu@...el.com>,
	linux-wireless@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][RESEND] wireless: convert !X & Y to !(X & Y) in
	iwl4965_is_fat_tx_allowed()

On Tue, Mar 25, 2008 at 09:30:58AM -0700, Chatre, Reinette wrote:
> On Tuesday, March 25, 2008 9:04 AM, Roel Kluin  wrote:
> 
> > from include/linux/ieee80211.h:274:
> > #define IEEE80211_HT_CAP_SUP_WIDTH              0x0002 ---
> > ! has a higher priority than &
> > 
> > Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> > ---
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c
> > b/drivers/net/wireless/iwlwifi/iwl-4965.c
> > index d727de8..6576757 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
> > @@ -4589,7 +4589,7 @@ static u8
> > iwl4965_is_fat_tx_allowed(struct iwl4965_priv *priv,
> > 
> > 	if (sta_ht_inf) {
> > 		if ((!sta_ht_inf->ht_supported) ||
> > -		   (!sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH))
> > +		   (!(sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH)))
> return 0;
> > 	}
> 
> This patch has already been acked and merged into wireless-testing, and
> afaik already pushed further upstream.

Yes, but FWIW the problem exists in the 2.6.25 stream as well.
I've been holding-back a patch to fix it there, trying to decide if it
is worth creating the merge conflict to fix it there.  I'm inclined
to think it is better to let things lay as they are and send that
patch for the -stable series once 2.6.25 ships.

Any thoughts on that?

John
-- 
John W. Linville
linville@...driver.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/