linux-kernel - Re: [patch] bkl2mtd: cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080326110247.GE17176@elte.hu>
Date:	Wed, 26 Mar 2008 12:02:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	J?rn Engel <joern@...fs.org>, David Miller <davem@...emloft.net>,
	jirislaby@...il.com, joe@...ches.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...dowen.org>
Subject: Re: [patch] bkl2mtd: cleanup


* Al Viro <viro@...IV.linux.org.uk> wrote:

> > -		if (ret) {
> > +		if (ret)
> >  			parse_err("illegal erase size");
> > -		}
> >  	}
> 
> BTW, I certainly wouldn't inflict that on patches; at some point in 
> series the body of if may shrink to one line only to get longer in the 
> next patch.  Removing and restoring {} would only add noise.

agreed, we dont enforce it strictly - it is the end result that must be 
clean.

[ OTOH, when i create a patch series i personally always try to make 
  each patch clean, because one never knows when a later patch gets 
  delayed or dropped altogether. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/