linux-kernel - Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080326.044802.107678511.davem@davemloft.net>
Date:	Wed, 26 Mar 2008 04:48:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joern@...fs.org
Cc:	mingo@...e.hu, apw@...dowen.org, jirislaby@...il.com,
	viro@...IV.linux.org.uk, joe@...ches.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups
 - formatting only

From: Jörn Engel <joern@...fs.org>
Date: Wed, 26 Mar 2008 12:41:42 +0100

> Do you have a non-consistency based reason to prefer the longer
> version?

Inconstent spacing fools people's eyes and leads to bugs,
more often than not.

After 15 years of kernel development, I can remember at
least 10 or so multi-week-debugging sessions that could
have been curtailed had I not mis-read a poorly spaced
C statement.

It matters in practical terms, not just consistency terms,
trust me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/