linux-kernel - Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080326114142.GD22847@logfs.org>
Date:	Wed, 26 Mar 2008 12:41:42 +0100
From:	Jörn Engel <joern@...fs.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andy Whitcroft <apw@...dowen.org>,
	David Miller <davem@...emloft.net>, jirislaby@...il.com,
	viro@...IV.linux.org.uk, joe@...ches.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups - formatting only

On Wed, 26 March 2008 12:23:11 +0100, Ingo Molnar wrote:
> * Jörn Engel <joern@...fs.org> wrote:
> 
> > 
> > Then I'll happily ignore it.  Not having the space gains me one 
> > column. It is absolutely minimal, sure.  But when the alternative is 
> > based on pure whim...
> 
> you seem to be confused here. Consistency is not a 'whim', and it is 
> often just about "arbitrary" choices that also have some ergonomic 
> component as well (but sometimes not). The following form:

I have an objective reason to prefer one over the other.  Your only
reason is consistency.  If consistency was everything, we might as well
let the often-abused 1000 monkeys type up a coding style document and
stick to that.

But most of our rules exist for reasons beyond mere consistency.
Following the rules, on average, makes the code better.  In particular
the "less" rules (fewer lines, less indentation, etc.) result in more
code fitting any arbitrary editor window.  Which means more control flow
our mind can ponder about without scrolling.

Do you have a non-consistency based reason to prefer the longer version?
If not, then we should settle on the short version, which does have a
minimal advantage.

Jörn

-- 
Joern's library part 13:
http://www.chip-architect.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/